[asterisk-bugs] [Asterisk 0009939]: Transfer implementation

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9939 
====================================================================== 
Reported By:                wedhorn
Assigned To:                qwell
====================================================================== 
Project:                    Asterisk
Issue ID:                   9939
Category:                   Channels/chan_skinny
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     assigned
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 67843 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             06-11-2007 04:33 CDT
Last Modified:              08-07-2007 10:05 CDT
====================================================================== 
Summary:                    Transfer implementation
Description: 
Initial patch adding transfer to chan_skinny. Works, but lots of bugs and
more work to be done. Basic functionality is <XFER> to start transfer, puts
call on hold and gives you a dialtone. Dial number and after connected
press <XFER> again and call is transferred.

After first <XFER> press and before call ringing/connected, you can press
<XFER> again to use a blind transfer. In this case transfer occurs when
either channel being dialed indicates ringing or answering. When in blind
transfer you can press <XFER> again to go back to attended transfer.

<HOLD> toggles between the transferee and transferor.
====================================================================== 

---------------------------------------------------------------------- 
 DEA - 08-07-07 10:05  
---------------------------------------------------------------------- 
The packet structure and callstate fixes should be completely merged
at this time.  I found and fixed more than what was in this patch set.

The hold and redial cleanup patches are lingering attached to a closed
bug report and I should get them updated and attached to their own bug.

I have not had a chance to look at this patch recently, so I am not sure
if you were able to maintain my fixes for the subchannel list handling.
The current code in Trunk and Branches/1.4 does not appear to ever free
a sub at the end of a call.  New subs get inserted to the head of the
lines
subchannel list, so there is not a huge performance issue, but I think we
are leaking small amounts of memory.  I also think that we will want/need
to properly handle cleanup subchannels if we want to support multiple
calls
per line (1 active, others on hold)

I am away from my development system this week, so I cannot  offer much
other than code review.

On the subchannel handling front, I've noticed that Qwell has a branch
with
all of the link-lists converted to the AST_* macros.  I think we could
make
a big jump forward if that branch could be merged to Trunk.  It's a big
change,
but we seem to have a good group of interested developers that can handle
any
clean-up required. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-07-07 10:05  DEA            Note Added: 0068535                          
======================================================================