[asterisk-bugs] [Zaptel 0009909]: [patch] ZT_VMWI: ioctl for Voicemail Message Waiting Indication

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=9909 
====================================================================== 
Reported By:                tzafrir
Assigned To:                
====================================================================== 
Project:                    Zaptel
Issue ID:                   9909
Category:                   NewFeature
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Zaptel Version:              SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 2591 
Disclaimer on File?:        Yes 
Request Review:              
====================================================================== 
Date Submitted:             06-07-2007 09:35 CDT
Last Modified:              08-06-2007 12:38 CDT
====================================================================== 
Summary:                    [patch] ZT_VMWI: ioctl for Voicemail Message Waiting
Indication
Description: 
There are several phones that support voicemail message indication through
an FSK message with the messages count after placing the phone off-hook.

Asterisk currently notifies the user / handset about waiting message in
two ways:

1. stuter tone
2. FSK 

Those are implemented by tones that Asterisk sends down the line
transparently to Zaptel.

A third way to support this is to light an analog neon led. However this
cannot be done merely by sending tones, and has to be implemented by the
lower-level driver. 

The xpp driver currently implements those changes, though  it has to
detect the fact that Asterisk sent a VoiceMail indication through detecting
the FSK tone. This is obviously wrong, as this information is available.

We would like to give the userspace programs the ability to signal the
Zaptel driver to start / stop signaling a VoiceMail message to the phone.
For that functionality we propose a new ioctl: ZT_VMWI

The attached patches:

vmmi_zaptelh.diff:
A patch to zaptel.h: a patch to add the new ioctl

vs. zaptel 1.4.2.1.

vmmi_xpp.diff:
Implementation in our driver. Actually a fix to the existing
implementation. 

(Revision numbers in both refer to our internal SVN, and not to the Zaptel
SVN).

vmmi_asterisk.diff:
A patch to chan_zap.c (from trunk) as a sample implementation.
====================================================================== 

---------------------------------------------------------------------- 
 mattf - 08-06-07 12:38  
---------------------------------------------------------------------- 
tzafrir, First pass says this looks very non intrusive.  It doesn't appear
to break anything else either, so that's 2 points for you :-)  Can you
document the ioctl better where you define it?  I.E., give some sort of
detailed documentation about why/when it is useful?  After that, I think
it's committable. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-06-07 12:38  mattf          Note Added: 0068507                          
======================================================================