[asterisk-bugs] [Asterisk 0010361]: [patch] vnak_retransmit sends out incorrect frames

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10361 
====================================================================== 
Reported By:                mihai
Assigned To:                russell
====================================================================== 
Project:                    Asterisk
Issue ID:                   10361
Category:                   Channels/chan_iax2
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
Asterisk Version:           1.4.9  
SVN Branch (only for SVN checkouts, not tarball releases): N/A  
SVN Revision (number only!):  
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-01-2007 15:23 CDT
Last Modified:              08-02-2007 11:36 CDT
====================================================================== 
Summary:                    [patch] vnak_retransmit sends out incorrect frames
Description: 
vnak_retransmit should do some more exhaustive checks on the frames it
sends out as a reply to a VNAK:
- check if retries == -1 (if true, the frame was marked for deletion)
- check if the destination callno of the frame is equal to our call's
destination callno
====================================================================== 

---------------------------------------------------------------------- 
 russell - 08-02-07 11:36  
---------------------------------------------------------------------- 
I think I'm going to commit only the "retries" check part.  I can't think
of any case where the peer call number check would be beneficial unless the
code was broken.

...

On second thought, I think checking the peer call number could actually
cause a problem.  Specifically, the first frame of a session doesn't have
the peer's call number in it.  This check would prevent it from getting
retransmitted. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-02-07 11:36  russell        Note Added: 0068321                          
======================================================================