[asterisk-bugs] [Asterisk 0010365]: [patch] Add manager command shell for accessing the system shell

[noreply at bugs.digium.com]

A NOTE has been added to this issue. 
====================================================================== 
http://bugs.digium.com/view.php?id=10365 
====================================================================== 
Reported By:                bkruse
Assigned To:                
====================================================================== 
Project:                    Asterisk
Issue ID:                   10365
Category:                   Core/ManagerInterface
Reproducibility:            N/A
Severity:                   feature
Priority:                   normal
Status:                     new
Asterisk Version:            SVN 
SVN Branch (only for SVN checkouts, not tarball releases):  trunk 
SVN Revision (number only!): 77884 
Disclaimer on File?:        N/A 
Request Review:              
====================================================================== 
Date Submitted:             08-01-2007 16:24 CDT
Last Modified:              08-01-2007 21:16 CDT
====================================================================== 
Summary:                    [patch] Add manager command shell for accessing the
system shell
Description: 
This is just a quick patch for doing a system call from manager.

action:shell: Manager command "shell" - executes a command as if you were
at the shell environment

syntax:

action: shell
command: echo "haha" > /verifyworks


Will execute that command at the shell.

action: shell
command: echo "you'll see this in the return message"
getvar: true

________________________________________________________________

Current problems, if you do a system command, from the gui, try to
get the input back, will it freeze the connection if shell does not
return?

Example:
action: shell
command: while true; do echo "this will never exit :/" ; done
getvar: true

If getvar was not set, it should be fine. I am not sure of a way to
prevent
the user from doing this anyways. 



====================================================================== 

---------------------------------------------------------------------- 
 juggie - 08-01-07 21:16  
---------------------------------------------------------------------- 
I am not sure this is wise, given that asterisk manager login is a clear
text login, being able to sniff that then execute shell commands is very
bad (TM) something which may have a better chance would be lets say pre
configuring manager commands in say manager_shell.conf which could be like,


[network_restart]
shell=/sbin/service network restart

then you would do action: shell network_restart

of course you could also extend that to do say,

action: shell network_restart eth0 which should pass eth0 to the shell
command as an arg upon execution.

This i believe would be safer, letting people run any arbitrary command
would be asking for trouble. 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
08-01-07 21:16  juggie         Note Added: 0068285                          
======================================================================