<div dir="ltr">On Thu, Dec 19, 2013 at 1:17 PM, Paul Belanger <span dir="ltr"><<a href="mailto:paul.belanger@polybeacon.com" target="_blank">paul.belanger@polybeacon.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On Wed, Dec 18, 2013 at 5:25 PM, Jonathan Rose <<a href="mailto:jrose@digium.com">jrose@digium.com</a>> wrote:<br>
</div><div class="im">> ARI Mailboxes resource<br>
><br>
> I'm currently starting on some basic implementation of the mailboxes<br>
> resource described at<br>
> <a href="https://wiki.asterisk.org/wiki/display/AST/Blinky+Lights+API" target="_blank">https://wiki.asterisk.org/wiki/display/AST/Blinky+Lights+API</a><br>
><br>
> Data Model:<br>
><br>
> name: string name of the mailbox<br>
><br>
</div>Prefer to see ID vs name, since both are strings don't see it being an issue.<br></blockquote><div><br></div><div>Well, this is a very similar model to deviceStates, which uses 'name' for the property. ID kind of implies that it's something</div>
<div>that will be generated within Asterisk doesn't it? Like with a channel ID or the bridge ID... the user/stasis application</div><div>doesn't have any ability to set that. Meanwhile I added a new field to bridges the other day that allows a name to be</div>
<div>explicitly set for the bridge. I suppose one difference in this case is that the name has some guarantee of uniqueness, but</div><div>the existing precedent is still to use 'name' for this property rather than ID.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im"><br>
> new_messages: int count of messages that have not been marked as old<br>
> old_messages: int count of messages that have been marked as old<br>
><br>
</div>maybe even 1 step further:<br>
<br>
newMsgs = msgcount<br>
oldMsgs = msgcount<br>
newUrgentMsgs = msgcount<br>
oldUrgentMsgs = msgcount</blockquote><div><br></div><div>from <a href="https://reviewboard.asterisk.org/r/3061/diff/#index_header">https://reviewboard.asterisk.org/r/3061/diff/#index_header</a> :</div><div><br></div><div>
<table class="" id="file49870" style="border:1px solid rgb(192,192,192);border-collapse:collapse;margin:2px 2px 20px;padding:2px;width:1638px;color:rgb(0,0,0);font-family:Verdana,Arial,Helvetica,sans-serif;font-size:11px">
<tbody id="chunk3.0" class=""><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top"></th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
</pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">71</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
<span class="" style="font-weight:bold">struct</span> <span class="">ast_mwi_mailbox_object</span> <span class="">{</span></pre></td></tr><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">
</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"></pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">
72</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"><span class=""> </span><span class="">SORCERY_OBJECT</span><span class="">(</span><span class="">details</span><span class="">);</span></pre>
</td></tr><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top"></th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
</pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">73</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
<span class=""> </span><span class="" style="color:rgb(0,0,192);font-style:italic">/*! Number of new messages in mailbox. */</span></pre></td></tr><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">
</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"></pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">
74</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"><span class=""> </span><span class="" style="font-weight:bold">unsigned</span> <span class="" style="font-weight:bold">int</span> <span class="">msgs_new</span><span class="">;</span></pre>
</td></tr><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top"></th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
</pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">75</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
<span class=""> </span><span class="" style="color:rgb(0,0,192);font-style:italic">/*! Number of old messages in mailbox. */</span></pre></td></tr><tr class=""><th style="background-color:rgb(154,226,152);padding-left:1em;text-align:right;vertical-align:top">
</th><td style="vertical-align:top;background-color:rgb(154,226,152)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"></pre></td><th style="background-color:rgb(154,226,152);padding-left:1em;text-align:right;vertical-align:top">
76</th><td style="vertical-align:top;background-color:rgb(154,226,152)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px"><span class=""> </span><span class="" style="font-weight:bold">unsigned</span> <span class="" style="font-weight:bold">int</span> <span class="" style="background-color:rgb(154,226,152)">msgs_old</span><span class="" style="background-color:rgb(154,226,152)">;</span></pre>
</td></tr><tr class=""><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top"></th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
</pre></td><th style="background-color:rgb(177,235,176);padding-left:1em;text-align:right;vertical-align:top">77</th><td style="vertical-align:top;background-color:rgb(197,255,196)"><pre style="font-size:8pt;white-space:pre-wrap;word-wrap:break-word;line-height:15px;margin-top:0px;margin-bottom:0px">
<span class="">};</span></pre></td></tr></tbody></table></div><div>I don't think the external MWI system is going to have any means of handling messages flagged as urgent.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
[1] <a href="http://tools.ietf.org/html/rfc3842" target="_blank">http://tools.ietf.org/html/rfc3842</a><br>
<br>
Also, case should be camelCase, not snake_case.<br></blockquote><div><br></div><div>I don't think SIP RFCs really apply to this discussion (this is all channel technology agnostic), but Swagger</div><div>won't actually allow model properties to contain uppercase characters anyway.</div>
<div><br></div></div>-- <br><div dir="ltr">Jonathan R. Rose<br>Digium, Inc. | Software Engineer<br>445 Jan Davis Drive NW - Huntsville, AL 35806 - US<br>direct +1 256 428 6139 <br><br>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> & <a href="http://asterisk.org" target="_blank">http://asterisk.org</a><br>
<br></div>
</div></div>